Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14332 )
Change subject: IMPALA-8962: FETCH_ROWS_TIMEOUT_MS should apply before rows are available ...................................................................... Patch Set 3: (2 comments) Addressed comments and made a few cosmetic changes. http://gerrit.cloudera.org:8080/#/c/14332/3/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/14332/3/be/src/runtime/coordinator.cc@687 PS3, Line 687: parent_request_state_->fetch_rows_timeout_us() : - parent_request_state_->block_on_wait_time_us > If by coincidence block_on_wait_time_us_ is the same as fetch_rows_timeout_ whoops, yeah that should be a max(1, ...) instead of max(0, ...). There was also a bug where timeout_us might not be set to 0, even if FETCH_ROWS_TIMEOUT_MS was 0. Fixed both issues. http://gerrit.cloudera.org:8080/#/c/14332/3/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/14332/3/be/src/service/client-request-state.h@353 PS3, Line 353: uint64_t block_on_wait_time_us_ = 0; > I think storing this per-query is incorrect since there could be multiple c Done -- To view, visit http://gerrit.cloudera.org:8080/14332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cba6bf062dcc1af19471d21857caa797c1ea4a4 Gerrit-Change-Number: 14332 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 03 Oct 2019 00:19:41 +0000 Gerrit-HasComments: Yes
