Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14381 )
Change subject: IMPALA-9015: improve mt_dop scan scheduling ...................................................................... Patch Set 3: (3 comments) This is ready for review now. http://gerrit.cloudera.org:8080/#/c/14381/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14381/1//COMMIT_MSG@22 PS1, Line 22: Updated admission test to reflect this change. > I should also write a few unit tests, the core method should be fairly unit Done http://gerrit.cloudera.org:8080/#/c/14381/1/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/14381/1/be/src/scheduling/scheduler.cc@408 PS1, Line 408: FInstanceExecParams& instance_params = fragment_params->instance_exec_params.back(); > Should probably mention why sorting in-place is OK Done http://gerrit.cloudera.org:8080/#/c/14381/1/be/src/scheduling/scheduler.cc@411 PS1, Line 411: } > Factor out into function. Done -- To view, visit http://gerrit.cloudera.org:8080/14381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ed2dab835efeb64bb74891cb43065894892682 Gerrit-Change-Number: 14381 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 07 Oct 2019 22:47:10 +0000 Gerrit-HasComments: Yes
