Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14381 )
Change subject: IMPALA-9015: improve mt_dop scan scheduling ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14381/3/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: http://gerrit.cloudera.org:8080/#/c/14381/3/be/src/scheduling/scheduler.h@391 PS3, Line 391: 'num_ranges' must be positive. May reorder ranges in : /// 'ranges'. > nit: update references to input variables. Oops. I think 'ranges' is a better name so I'm going to switch to that. -- To view, visit http://gerrit.cloudera.org:8080/14381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45ed2dab835efeb64bb74891cb43065894892682 Gerrit-Change-Number: 14381 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 02:01:07 +0000 Gerrit-HasComments: Yes
