Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 )
Change subject: IMPALA-8884: track storage read statistics per queue ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc@142 PS6, Line 142: // This parameter controls whether remote HDFS file handles are cached. It does not impact : // S3, ADLS, or ABFS file handles. : DEFINE_bool(cache_remote_file_handles, true, : "Enable the file handle cache for " : "remote HDFS files."); : : // This parameter controls whether S3 file handles are cached. : DEFINE_bool(cache_s3_file_handles, true, : "Enable the file handle cache for " : "S3 files."); The formatting fix didn't make it. http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc@289 PS6, Line 289: if (TestInfo::is_test() : && ImpaladMetrics::IO_MGR_METRICS->FindMetricForTesting<HistogramMetric>( : Substitute(DEVICE_NAME_METRIC_KEY_TEMPLATE, i_string)) : == nullptr) { Couple things: 1. I think this wouldn't set the device name outside of a test, because we would never do the AddProperty command. I think you want something like: bool device_name_set = false; if (TestInfo::is_test()) { device_name_set = (FindMetricForTesting() == null); } if (!device_name_set) { AddProperty(); } (Or store the actual property pointer) 2. What is the right type for a property? We are using FindMetricForTesting with a HistogramMetric for a property. It's only for existence checking, but is there a better template type to use for a property? -- To view, visit http://gerrit.cloudera.org:8080/14242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 Gerrit-Change-Number: 14242 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 08 Oct 2019 21:08:01 +0000 Gerrit-HasComments: Yes
