Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 )
Change subject: IMPALA-8884: track storage read statistics per queue ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc@142 PS6, Line 142: // This parameter controls whether remote HDFS file handles are cached. It does not impact : // S3, ADLS, or ABFS file handles. : DEFINE_bool(cache_remote_file_handles, true, : "Enable the file handle cache for " : "remote HDFS files."); : : // This parameter controls whether S3 file handles are cached. : DEFINE_bool(cache_s3_file_handles, true, : "Enable the file handle cache for " : "S3 files."); > The formatting fix didn't make it. Done http://gerrit.cloudera.org:8080/#/c/14242/6/be/src/runtime/io/disk-io-mgr.cc@289 PS6, Line 289: if (TestInfo::is_test() : && ImpaladMetrics::IO_MGR_METRICS->FindMetricForTesting<HistogramMetric>( : Substitute(DEVICE_NAME_METRIC_KEY_TEMPLATE, i_string)) : == nullptr) { > Couple things: Both good points. I restructured the conditional to be correct and confirmed the metric is created. Switched to StringProperty too. -- To view, visit http://gerrit.cloudera.org:8080/14242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8233ed02b418f22f1d0c031e378288357796f4b4 Gerrit-Change-Number: 14242 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Oct 2019 21:48:20 +0000 Gerrit-HasComments: Yes
