Csaba Ringhofer has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14402 )
Change subject: IMPALA-8831: Support ALTER TABLE for insert_only ACID tables ...................................................................... IMPALA-8831: Support ALTER TABLE for insert_only ACID tables ALTER TABLE commands were not allowed on ACID tables until now. This patch enables most ALTER TABLE statements for insert only tables. Generally ACID tables can be altered the same way as non-ACID tables, just an exclusive table lock needs to acquired before calling alter_table on HMS. There are a few exceptions: - ALTER TABLE SET TBLPROPERTIES and ADD PARTITION need only shared locks. - Stats related operations open a transaction currently and are handled separately. - ALTER TABLE RECOVER PARTITIONS makes no sense for ACID tables. - ALTER TABLE RENAME TO turned out to be more complicated, as HMS needs transactional information to migrate stats during rename. A follow up Jira is created to support rename: IMPALA-9031. Some .test files were split to parts based on whether it is possible to run those queries on ACID tables. As a result .test changes are nearly all copy paste. Change-Id: If05cd975fe702fdde1d9e8ab063c3ac440ff668c --- M fe/src/main/java/org/apache/impala/analysis/AlterTableOrViewRenameStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableRecoverPartitionsStmt.java M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java M fe/src/main/java/org/apache/impala/catalog/Catalog.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java A testdata/workloads/functional-query/queries/QueryTest/alter-table-rename.test A testdata/workloads/functional-query/queries/QueryTest/alter-table-set-column-stats-hbase.test M testdata/workloads/functional-query/queries/QueryTest/alter-table-set-column-stats.test A testdata/workloads/functional-query/queries/QueryTest/alter-table-with-existing-locations.test M testdata/workloads/functional-query/queries/QueryTest/alter-table.test M tests/metadata/test_ddl.py 12 files changed, 1,034 insertions(+), 885 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/14402/3 -- To view, visit http://gerrit.cloudera.org:8080/14402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If05cd975fe702fdde1d9e8ab063c3ac440ff668c Gerrit-Change-Number: 14402 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]>
