Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14402 )
Change subject: IMPALA-8831: Support ALTER TABLE for insert_only ACID tables ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/14402/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14402/4//COMMIT_MSG@13 PS4, Line 13: to acquired nit: to be acquired http://gerrit.cloudera.org:8080/#/c/14402/4//COMMIT_MSG@14 PS4, Line 14: alter_table nit: alter_table() http://gerrit.cloudera.org:8080/#/c/14402/4//COMMIT_MSG@19 PS4, Line 19: ALTER TABLE RECOVER PARTITIONS makes no sense for ACID tables. Pls mention that it results an error if the users tries to recover partitions for an acid table. http://gerrit.cloudera.org:8080/#/c/14402/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/14402/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@594 PS4, Line 594: AnalysisError( : "alter table functional_orc_def.full_transactional_table recover partitions", : errorMsg); The error msg here says that recover partition is not supported for this full acid table but gives the impression that it would work if the table was insert-only acid. "Transactional (ACID) tables are only supported when they are configured as insert_only." This is wrong in my opinion as RECOVER PARTITION is not supported for any kind of acid tables. http://gerrit.cloudera.org:8080/#/c/14402/4/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/14402/4/tests/metadata/test_ddl.py@427 PS4, Line 427: the nit: typo http://gerrit.cloudera.org:8080/#/c/14402/4/tests/metadata/test_ddl.py@437 PS4, Line 437: nit: 4 space indentation seemed correct as this line is broken into 2. http://gerrit.cloudera.org:8080/#/c/14402/4/tests/metadata/test_ddl.py@439 PS4, Line 439: same here. -- To view, visit http://gerrit.cloudera.org:8080/14402 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If05cd975fe702fdde1d9e8ab063c3ac440ff668c Gerrit-Change-Number: 14402 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2019 14:30:04 +0000 Gerrit-HasComments: Yes
