Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 )
Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES ...................................................................... Patch Set 3: > Patch Set 3: > > Code looks ok for solution that is described but I would like to know if we > considered a more elegant solution such as supporting ANY privilege in Sentry > or adding a clause to the SHOW TABLE grammar to display tables with certain > privileges. Having external flags that affect statement behavior is generally > bad practice. Yeah, I think supporting ANY privilege in Sentry more efficiently is a more elegant solution. But it's not what we can do in Impala side. I create a Sentry JIRA for this: https://issues.apache.org/jira/browse/SENTRY-2534. In the short term, we may need this patch. For adding a clause to the SHOW TABLE statement, it's not enough to cover the problem since HUE and JDBC drivers depend on the GET_TABLES interface of HS2 protocol. They can't change it easily so will still suffer the problem. So this new flag is for admin in short term to avoid the performance regression when they upgrade Impala to a version with fine-grained privileges. If they switch to use Ranger or if SENTRY-2534 is fixed, they can get rid of this totally. -- To view, visit http://gerrit.cloudera.org:8080/14400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17e2b7bf9e36c54627276a6812b459912156cc3c Gerrit-Change-Number: 14400 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 11 Oct 2019 01:11:16 +0000 Gerrit-HasComments: No
