Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14400 )
Change subject: IMPALA-9002: Add query option to only check SELECT privilege in SHOW TABLES ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patch looks good to me. Thanks for making the suggested changes. I think it is unlikely that Sentry patch for improving the privilege check will be merged soon. This patch provides a reasonable workaround for the user if they are hit with the slow privilege checks from Sentry on large setups. http://gerrit.cloudera.org:8080/#/c/14400/5/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/14400/5/be/src/common/global-flags.cc@278 PS5, Line 278: simplify_check_on_show_tables > This change the query behavior so I think admin should be aware of it. As s I see. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/14400/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14400/5/fe/src/main/java/org/apache/impala/service/Frontend.java@796 PS5, Line 796: PrivilegeRequest privilegeRequest = new PrivilegeRequestBuilder( : authzFactory_.getAuthorizableFactory()) : .allOf(requiredPrivilege).onAnyColumn(dbName, tblName, tableOwner).build(); : if (!authzChecker_.get().hasAccess(user, privilegeRequest)) { : iter.remove(); : } > Yeah, that's an optimization! But changing the order only helps if the user yeah, that makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/14400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17e2b7bf9e36c54627276a6812b459912156cc3c Gerrit-Change-Number: 14400 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2019 04:34:54 +0000 Gerrit-HasComments: Yes
