Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 )
Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14391/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14391/1//COMMIT_MSG@16 PS1, Line 16: Testing: Hmm, I wonder how difficult it would be to write an automated test for this, eg. in test_shell_interactive by specifying an invalid impalad hostname, running a "quit", and checking for "reconnecting" in the output. Not a big deal if its too complicated. -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2019 19:45:21 +0000 Gerrit-HasComments: Yes
