Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14391 )
Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/14391/2/tests/shell/test_shell_interactive.py@243 PS2, Line 243: result = run_impala_shell_interactive(vector, 'quit;', shell_args=['-ifoo'], > Maybe add a case with a different command that does result in a "reconnect" Good point, added a case that does reconnect -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2019 21:22:26 +0000 Gerrit-HasComments: Yes
