Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14391 )
Change subject: IMPALA-9028: impala-shell should not try to reconnect if quitting ...................................................................... IMPALA-9028: impala-shell should not try to reconnect if quitting When the impala-shell is disconnected, it will try to reconnect for any command that a user runs (as part of ImpalaShell's precmd()). This doesn't make sense when the user is trying to quit the shell (i.e. by typing 'quit' or 'exit' or hitting Ctrl-D). This skips the attempt to reconnect when quitting the shell. Testing: - Added test in test_shell_interactive.py - Verified by hand Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Reviewed-on: http://gerrit.cloudera.org:8080/14391 Reviewed-by: Thomas Tauber-Marshall <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M shell/impala_shell.py M tests/shell/test_shell_interactive.py 2 files changed, 23 insertions(+), 1 deletion(-) Approvals: Thomas Tauber-Marshall: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/14391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6a76bc515db609498fa8772e9f0b0c547b82c09e Gerrit-Change-Number: 14391 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
