Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 )
Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode ...................................................................... Patch Set 8: > Patch Set 6: > > (4 comments) > > Thanks Vihang's comments! > > > I looks like you are sending all the objects in the catalogd when you > > detect the reset. Is it possible to not send the objects and just > > invalidate the whole local catalog cache when you detect that the last > > reset version is changed? > > Reseting coordinator's local catalog is ok. But coordinator needs to know > when the reset() in catalogd finishs. For SYNC_DDL, it also needs to know the > catalog topic version (not catalog version, it's the version of the > statestore topic) so it can wait for other coordinators to be ready. I have > an explanation with code links in "Why can’t we simply reset the cache of > local catalog mode Coordinator for global INVALIDATE METADATA?" in the doc: > https://docs.google.com/document/d/1-AoigzsQPgSGosW4vtVP8E7TiwoJJfLkAq3Rd6KvKBg Ah, I realize what you say is different! It's a good idea to invalidate the whole cache when detecting last reset version is changed! Then we no longer need to change the skipping logics in catalogd, making this patch much simpler. Update the patch according to this. BTW, still contains the fix for IMPALA-9062. -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 21 Oct 2019 12:41:50 +0000 Gerrit-HasComments: No
