Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 )
Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode ...................................................................... Patch Set 10: (1 comment) Added custom cluster tests to cover bugs found in the review, i.e. 1) get table version without acquiring table lock in CatalogServiceCatalog.addTableToCatalogDeltaHelper() 2) concurrent INVALIDATE METADATA commands could downward the lastResetStartVersion_ http://gerrit.cloudera.org:8080/#/c/14307/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14307/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@763 PS8, Line 763: catalog.setCatalog(new TCatalog(catalogServiceId_, ctx.lastResetStartVersion)); > Yeah, good point! I'd like to have a try. I finally found that we should at least add the updated dbs and tables into topicUpdateLog_, otherwise DDLs with sync_ddl will hang in waitForSyncDdlVersion(). To add them into topicUpdateLog_, we should at least get their catalog versions. For tables we still need to acquire the table locks. So the existing code paths in this function can't be ignored. Finally, we still collect all TCatalogObjects for updated tables. In catalog-v2, these objects just contain table names. It's already light weght enough. So I don't want to add more if-else clauses to ignore them... -- To view, visit http://gerrit.cloudera.org:8080/14307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib61a7ab1ffa062620ffbc2dadc34bd7a8ca9e549 Gerrit-Change-Number: 14307 Gerrit-PatchSet: 10 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2019 16:05:12 +0000 Gerrit-HasComments: Yes
