Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container ...................................................................... Patch Set 1: (2 comments) A couple of quick notes http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc File be/src/util/os-info.cc: http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@56 PS1, Line 56: ifstream os_version("/etc/os-release", ios::in); I think this file is not present on Centos6. I *think* we still support that, though I am not 100% sure. http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@99 PS1, Line 99: << "Kernel version: " << kernel_version_ << endl If I were reading this I would be confused: what is OS version, what is Kernel version? Are they the same? If I am not in Docker what do I see? My suggestion: only if we are running in Docker print "Container OS: XXXX" -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 01:00:28 +0000 Gerrit-HasComments: Yes
