Xiaomeng Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )
Change subject: IMPALA-8065 OSInfo produces somewhat misleading output when running in container ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc File be/src/util/os-info.cc: http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@56 PS1, Line 56: ifstream os_version("/etc/os-release", ios::in); > I think this file is not present on Centos6. Thanks for finding this. I picked one version for each OS testing, which missed the special centos6. Added a catch up for case /etc/os-release doesn't exist. http://gerrit.cloudera.org:8080/#/c/14531/1/be/src/util/os-info.cc@99 PS1, Line 99: << "Kernel version: " << kernel_version_ << endl > If I were reading this I would be confused: what is OS version, what is Ker OS version is distribution version, and kerbel version is linux version. I don't have a better idea of distinguish them. For docker display, I search online, there is no guaranteed way to find it's running in a docker container. There are all kinds situation and we don't want to provide wrong info. -- To view, visit http://gerrit.cloudera.org:8080/14531 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a Gerrit-Change-Number: 14531 Gerrit-PatchSet: 1 Gerrit-Owner: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Xiaomeng Zhang <xiaom...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Oct 2019 21:44:51 +0000 Gerrit-HasComments: Yes
