Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14422 )
Change subject: IMPALA-8738: Extend "show tables" to return values other than the table name ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Thanks for your work on this! I'm not an expert on this particular area of the code, so I'll see if I can find someone who is to get this to a +2 http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1961 PS6, Line 1961: ParserError(String.format("SHOW %s TABLES tablename", extended)); Might as well move this up with the other "SHOW TABLES" cases so that we only have to have one for loop -- To view, visit http://gerrit.cloudera.org:8080/14422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63057c9d2fc453f95c6890bdc90e11c61a98a419 Gerrit-Change-Number: 14422 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2019 19:16:42 +0000 Gerrit-HasComments: Yes
