Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14422 )
Change subject: IMPALA-8738: Extend "show tables" to return values other than the table name ...................................................................... Patch Set 6: Code-Review+1 (3 comments) Thanks for the code changes. I think it already pretty well reviewed thanks to Thomas. I have very minor code style nits, other than that Thomas can go ahead and give a +2. http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java: http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/main/java/org/apache/impala/analysis/ShowTablesStmt.java@54 PS6, Line 54: isExtended Nit: Class variables are represented with trailing underscore. Do you mind changing this to "isExtended_"? http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/main/java/org/apache/impala/service/Frontend.java@814 PS6, Line 814: tbl_types Nit: We use camel case for variables. Do you mind changing this to tblTypes? http://gerrit.cloudera.org:8080/#/c/14422/6/fe/src/main/java/org/apache/impala/service/Frontend.java@823 PS6, Line 823: UNSUPPORTED NIT: "UNSUPPORTED" table type can be confusing. Could there be a better way to tell users the table has not been loaded and hence this information is not available? How about "UNAVAILABLE"? -- To view, visit http://gerrit.cloudera.org:8080/14422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63057c9d2fc453f95c6890bdc90e11c61a98a419 Gerrit-Change-Number: 14422 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2019 23:25:57 +0000 Gerrit-HasComments: Yes
