Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13794 )
Change subject: IMPALA-8709: Add Damerau-Levenshtein edit distance built-in function ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13794/1/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13794/1/be/src/exprs/string-functions-ir.cc@1177 PS1, Line 1177: int d[s1len + 1][s2len + 1]; > Yeah, usually we don't allocate that much memory on the stack because we re Changed VLA on stack to dynamic allocation. http://gerrit.cloudera.org:8080/#/c/13794/1/be/src/exprs/string-functions-ir.cc@1218 PS1, Line 1218: d[i][j] = std::min(d[i][j], : d[i - 2][j - 2] + l_cost // transposition : ); > nit: fits single line Done http://gerrit.cloudera.org:8080/#/c/13794/3/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13794/3/be/src/exprs/string-functions-ir.cc@1220 PS3, Line 1220: ); > nit: you could just put it before the comment from the prev line. Done -- To view, visit http://gerrit.cloudera.org:8080/13794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib759817ec15e7075bf49d51e494e45c8af4db94d Gerrit-Change-Number: 13794 Gerrit-PatchSet: 1 Gerrit-Owner: Greg Rahn <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2019 12:12:06 +0000 Gerrit-HasComments: Yes
