Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13794 )
Change subject: IMPALA-8709: Add Damerau-Levenshtein edit distance built-in function ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13794/4/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/13794/4/be/src/exprs/string-functions-ir.cc@1239 PS4, Line 1239: if (matching_characters == 0) return DoubleVal(0.0); > Alternatively, you could use MakeScopeExitTrigger(). Since it applies to more functions of this file, it would be more consistent to change there as well. But then it would be clearer to apply these changes in a separate commit, I think . -- To view, visit http://gerrit.cloudera.org:8080/13794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib759817ec15e7075bf49d51e494e45c8af4db94d Gerrit-Change-Number: 13794 Gerrit-PatchSet: 4 Gerrit-Owner: Greg Rahn <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2019 09:13:27 +0000 Gerrit-HasComments: Yes
