Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14549 )
Change subject: IMPALA-9095: Alter table events generated by renames should apply renames properly. ...................................................................... Patch Set 3: (2 comments) Thanks for a quick review! Addressed your comments. http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1964 PS2, Line 1964: public boolean renameTableIfExists(TTableName oldTableName, > The debug log in MetastoreEvents#process() is stale now. It says "Did not r Done. http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1971 PS2, Line 1971: newDb != null > BTW, can we create a follow-up JIRA to deal with unloaded newDb? Otherwise, I added some comments in AlterTableEvent's process() method. In general this is a common pattern in the events processor, we skip the event if the db objects in the event are not in the catalog anymore. Did you have anything different in mind that needs to be document? -- To view, visit http://gerrit.cloudera.org:8080/14549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bf46a75cd872aba268e15dd7c02c2cb46d64890 Gerrit-Change-Number: 14549 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2019 23:56:13 +0000 Gerrit-HasComments: Yes
