Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14549 )
Change subject: IMPALA-9095: Alter table events generated by renames should apply renames properly. ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14549/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1971 PS2, Line 1971: newDb != null > I added some comments in AlterTableEvent's process() method. In general thi Ah, I was thinking user creates a new db and alter an existing table into it, then we may skip this event if the db is unknown to Impala yet. But actually, the create db event will arrive before this alter event. So I'm wrong and don't need to document anything. -- To view, visit http://gerrit.cloudera.org:8080/14549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bf46a75cd872aba268e15dd7c02c2cb46d64890 Gerrit-Change-Number: 14549 Gerrit-PatchSet: 3 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 26 Oct 2019 00:08:59 +0000 Gerrit-HasComments: Yes
