Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14582
to look at the new patch set (#2).
Change subject: IMPALA-8879: Fix wrong active tabs after bootstrap upgrade
......................................................................
IMPALA-8879: Fix wrong active tabs after bootstrap upgrade
After upgrading Bootstrap to 4.3.1 in the previous patch, the query page
no longer highlights which tab is being used. This is due to the removal
of ".nav-tabs > li.active > a" in bootstrap.css. So li elements in
"active" class no longer has additional styles. Instead, the styles of
"active" class is moved into to "nav-link" class in Bootstrap 4. We
should add the "active" class in the "nav-link" elements instead.
Tests:
- Manually click throught all tabs to check the active state
Change-Id: I5c746bc4f49b30df54bd3c73ac6f1cf838260c65
---
M www/jvm-threadz.tmpl
M www/query_backends.tmpl
M www/query_detail_tabs.tmpl
M www/query_finstances.tmpl
M www/query_memory.tmpl
M www/query_plan.tmpl
M www/query_plan_text.tmpl
M www/query_profile.tmpl
M www/query_stmt.tmpl
M www/query_summary.tmpl
M www/threadz.tmpl
M www/threadz_tabs.tmpl
12 files changed, 28 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/14582/2
--
To view, visit http://gerrit.cloudera.org:8080/14582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c746bc4f49b30df54bd3c73ac6f1cf838260c65
Gerrit-Change-Number: 14582
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
