Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14582 )
Change subject: IMPALA-8879: Fix wrong active tabs after bootstrap upgrade ...................................................................... IMPALA-8879: Fix wrong active tabs after bootstrap upgrade After upgrading Bootstrap to 4.3.1 in the previous patch, the query page no longer highlights which tab is being used. This is due to the removal of ".nav-tabs > li.active > a" in bootstrap.css. So li elements in "active" class no longer has additional styles. Instead, the styles of "active" class is moved into to "nav-link" class in Bootstrap 4. We should add the "active" class in the "nav-link" elements instead. Tests: - Manually click throught all tabs to check the active state Change-Id: I5c746bc4f49b30df54bd3c73ac6f1cf838260c65 Reviewed-on: http://gerrit.cloudera.org:8080/14582 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M www/jvm-threadz.tmpl M www/query_backends.tmpl M www/query_detail_tabs.tmpl M www/query_finstances.tmpl M www/query_memory.tmpl M www/query_plan.tmpl M www/query_plan_text.tmpl M www/query_profile.tmpl M www/query_stmt.tmpl M www/query_summary.tmpl M www/threadz.tmpl M www/threadz_tabs.tmpl 12 files changed, 28 insertions(+), 24 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5c746bc4f49b30df54bd3c73ac6f1cf838260c65 Gerrit-Change-Number: 14582 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
