Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14422 )
Change subject: IMPALA-8738: "show extended tables" to return more than the table name ...................................................................... Patch Set 8: Not a LocalCatalog expert, but when LocalCatalogMode is turned on, impalads will fetch a per-query copy of the metadata on demand. The tests are run with this mode on. In the test failure, the localCatalog for "show extended '*'; " is trying to load the metadata for all tables (*) and instantiate the table subclass. However, there is no subclass for datasource table, which means those tables cannot be instantiated this way. See: https://github.com/apache/impala/blob/28b1d53f9cb7581974dfc0b2dd75f2f015c1c6b9/fe/src/main/java/org/apache/impala/catalog/local/LocalTable.java#L98 In short, I think we should disable 'show extended tables '*' " or any similar tests that try to fetch metadata for "ALL" tables and re-run the tests. If not done already, It will good to test these codepaths with LocalCatalog mode on, you can do that using: bin/start-impala-cluster.py --impalad_args="--use_local_catalog=true" --catalogd_args="--catalog_topic_mode=minimal" -- To view, visit http://gerrit.cloudera.org:8080/14422 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63057c9d2fc453f95c6890bdc90e11c61a98a419 Gerrit-Change-Number: 14422 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2019 19:14:51 +0000 Gerrit-HasComments: No
