Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/14547 )
Change subject: IMPALA-9045: Filter base directories of open/aborted compactions ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14547/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/14547/1/fe/src/main/java/org/apache/impala/catalog/FileMetadataLoader.java@79 PS1, Line 79: * compactions. : * @param writeIds if non-null, a write-id list which will fi > Replace TODO with the new argument. Done http://gerrit.cloudera.org:8080/#/c/14547/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14547/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@581 PS1, Line 581: > Yeah, it is hard for me to imagine such a fast compaction, but it is possib Added a TODO comment. I think the removal of old transactional directories is more concerning. -- To view, visit http://gerrit.cloudera.org:8080/14547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb895df38bc075e4767e44a6887dbe3000a19ea6 Gerrit-Change-Number: 14547 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2019 18:12:37 +0000 Gerrit-HasComments: Yes
