Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14547 )
Change subject: IMPALA-9045: Filter base directories of open/aborted compactions ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14547/2/fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java File fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java: http://gerrit.cloudera.org:8080/#/c/14547/2/fe/src/test/java/org/apache/impala/util/AcidUtilsTest.java@157 PS2, Line 157: "base_0000003_v0003217/000000_0", Hmm, shouldn't this fail because of passing default ValidReadTxnList in assertFiltering()? Or the default means that all transactions are committed? Can you add 1-2 tests where you set the valid transaction list too in assertFiltering? test_acid.py only checks a simple case with 1 base dir, it would be nice to verify that always the last base with valid writeId and committed transaction is chosen. -- To view, visit http://gerrit.cloudera.org:8080/14547 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb895df38bc075e4767e44a6887dbe3000a19ea6 Gerrit-Change-Number: 14547 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Nov 2019 19:00:02 +0000 Gerrit-HasComments: Yes
