Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 )
Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@255 PS7, Line 255: : Pass the correc > Observability changes like show create are not fully functional in this cha I see, thanks. http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@958 PS7, Line 958: new PrimaryKeysRequest(msTbl.getDbName(), msTbl.getTableName()))); : // Get foreign keys info. : foreignKeys_.addAll(client.getForeignKeys(new ForeignKeysRequest(null,null, : msTbl.getDbName(),msTbl.getTableName()))); : } : loadValidWriteIdList(client); > Moved them under loadTableSchema. For the RPC calls, wouldn't users always hmm. I don't think having a flag for this makes sense. So may we can leave it this way for now. Also, just noticed that we are doing addAll here. This means that the primaryKeys_ will keep accumulating everytime the table is loaded. The right thing to do is to re-initialize or clean and then add. Right? -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 8 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 01:53:30 +0000 Gerrit-HasComments: Yes
