Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 )
Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. ...................................................................... Patch Set 9: (1 comment) Thanks for catching that one. I added reset before keys are loaded. Moved loading of pk/fk to a helper method. Tested multiple loads of tables don't accumulate the keys. http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14592/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@958 PS7, Line 958: loadValidWriteIdList(client); : // Load partition and file metadata : if (reuseMetadata) { : // Incrementally update this table's partitions and file metadata : Preconditions.checkState( : partitionsToUpdate == null || loadPariti > hmm. I don't think having a flag for this makes sense. So may we can leave Oops! That would have been disastrous! Thanks for catching that Vihang. -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 9 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 02:39:26 +0000 Gerrit-HasComments: Yes
