Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14665 )
Change subject: IMPALA-9131: Use single quotes around FORMAT clause in CAST ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14665/2/be/src/runtime/datetime-iso-sql-format-tokenizer.cc File be/src/runtime/datetime-iso-sql-format-tokenizer.cc: http://gerrit.cloudera.org:8080/#/c/14665/2/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@237 PS2, Line 237: ++(*current_pos); Giving this a second thought it sounds a bit weird if an IsSomething() function has a side effect of also increasing a pointer or such. This works at least so it's good for a PoC but I'll try to find an alternative way. -- To view, visit http://gerrit.cloudera.org:8080/14665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3310abfa6f3ccbbe4c437846c6dd05791153e6f7 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward (536) Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 20:16:18 +0000 Gerrit-HasComments: Yes
