Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14665 )
Change subject: IMPALA-9131: Use single quotes around FORMAT clause in CAST ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14665/2/be/src/runtime/datetime-iso-sql-format-tokenizer.cc File be/src/runtime/datetime-iso-sql-format-tokenizer.cc: http://gerrit.cloudera.org:8080/#/c/14665/2/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@237 PS2, Line 237: ++(*current_pos); > Giving this a second thought it sounds a bit weird if an IsSomething() func Well, leaving it this way wouldn't cause any harm as calling this function multiple times would still produce the same result. Anyway, I haven't found any better solution. http://gerrit.cloudera.org:8080/#/c/14665/2/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@246 PS2, Line 246: strncasecmp(*current_pos, "FX" > Not this change, but i think this should be strncasecmp(..) instead. Format I added the fix to this patch (didn't want to create a new jira and handle it separately.) http://gerrit.cloudera.org:8080/#/c/14665/2/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/14665/2/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@209 PS2, Line 209: } else { > This still needs to be fixed: Indeed, i have fixed everything but the original issue with my previous patches :) Done -- To view, visit http://gerrit.cloudera.org:8080/14665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3310abfa6f3ccbbe4c437846c6dd05791153e6f7 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (536) Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Nov 2019 09:48:24 +0000 Gerrit-HasComments: Yes
