Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14714 )
Change subject: IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14714/3/be/src/runtime/date-parse-util.cc File be/src/runtime/date-parse-util.cc: http://gerrit.cloudera.org:8080/#/c/14714/3/be/src/runtime/date-parse-util.cc@160 PS3, Line 160: case MONTH_NAME_SHORT: { : result.append(FormatMonthName(month, tok)); : break; : } Using MONTH_NAME_SHORT both for "MMM" (simple format) and "MON" (ISO SQL format) tokens introduces a backward compatibility bug here: "DDD" should always be formatted as a capitalized string (e.g. "Jan"), but after this change it will be formatted as a full-uppercase string ("JAN") because "DDD" is full-uppercase. This breaks some BE-tests too (in date-test and timestamp-test). -- To view, visit http://gerrit.cloudera.org:8080/14714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f Gerrit-Change-Number: 14714 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2019 13:06:38 +0000 Gerrit-HasComments: Yes
