Hello Attila Jeges, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14714
to look at the new patch set (#5).
Change subject: IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3
......................................................................
IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3
This patch adds additional datetime format tokens on top of
Milestone 1 (IMPALA-8703) and Milestone 2 (IMPALA-8704).
The tokens introduced:
- Full month name (MONTH, Month, month): In a string to datetime
conversion this token can parse textual month name into a datetime
type. In a datetime to string conversion this token gives the
textual representation of a month.
- Short month name (MON, Mon, mon): Similar to the full month name
token but this works for 3-character month names like 'JAN'.
- Full day name (DAY, Day, day): In a datetime to string conversion
this token gives the textual representation of a day like
'Tuesday.' Not suppported in a string to datetime conversion.
- Short day name (DY, Dy, dy): Similar to full day name token but
this works for 3-character day names like 'TUE'.
- Day of week (D): In a datetime to string conversion this gives a
number in [1-7] where 1 represents Sunday. Not supported in a
string to datetime conversion.
- Quarter of year (Q): In a datetime to string conversion this gives
a number in [1-4] representing a quarter of the year. Not supported
in a string to datetime conversion.
- Week of year (WW): In a datetime to string conversion this gives a
number in [1-53] to represent the week of year where the first week
starts from 1st of January. Not supported in a string to datetime
conversion.
- Week of month (W): In a datetime to string conversion this gives a
number in [1-5] to represent the week of month where the first week
starts from the first day of the month. Not supported in a string
to datetime conversion.
Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f
---
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/benchmarks/parse-timestamp-benchmark.cc
M be/src/common/init.cc
M be/src/exprs/date-functions-ir.cc
M be/src/exprs/timestamp-functions-ir.cc
M be/src/exprs/timestamp-functions.cc
M be/src/exprs/timestamp-functions.h
M be/src/runtime/date-parse-util.cc
M be/src/runtime/date-parse-util.h
M be/src/runtime/datetime-iso-sql-format-parser.cc
M be/src/runtime/datetime-iso-sql-format-parser.h
M be/src/runtime/datetime-iso-sql-format-tokenizer.cc
M be/src/runtime/datetime-parser-common.cc
M be/src/runtime/datetime-parser-common.h
M be/src/runtime/datetime-simple-date-format-parser.cc
M be/src/runtime/datetime-simple-date-format-parser.h
M be/src/runtime/timestamp-parse-util.cc
M tests/query_test/test_cast_with_format.py
18 files changed, 1,063 insertions(+), 101 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/14714/5
--
To view, visit http://gerrit.cloudera.org:8080/14714
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f
Gerrit-Change-Number: 14714
Gerrit-PatchSet: 5
Gerrit-Owner: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>