Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 )
Change subject: IMPALA-9181: Serialize TQueryCtx once per query ...................................................................... Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/runtime/coordinator-backend-state.cc@215 PS3, Line 215: unique_ptr<kudu::faststring> sidecar_buf = make_unique<kudu::faststring>(); : sidecar_buf->assign_copy(serialized_buf, serialized_len); : unique_ptr<RpcSidecar> rpc_sidecar = RpcSidecar::FromFaststring(move(sidecar_buf)); Not this change but this can in theory be converted to sidecar using Slice too. That said, we may better hold off from doing so now until we convert ExecQueryFInstance() RPC to asynchronous as the memory management is slightly different in that case. May be a TODO for now is sufficient. http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/service/control-service.cc@120 PS3, Line 120: Status GetSidecar(int sidecar_idx, RpcContext* rpc_context, T* thrift_obj) { static -- To view, visit http://gerrit.cloudera.org:8080/14777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a4dd302fd5602ec2775492a041ddd51e7d7a6c6 Gerrit-Change-Number: 14777 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Nov 2019 00:09:52 +0000 Gerrit-HasComments: Yes
