Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14777 )
Change subject: IMPALA-9181: Serialize TQueryCtx once per query ...................................................................... Patch Set 4: Code-Review+2 (2 comments) carrying forward http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/runtime/coordinator-backend-state.cc@215 PS3, Line 215: // TODO: eliminate the extra copy here by using a Slice : unique_ptr<kudu::faststring> sidecar_buf = make_unique<kudu::faststring>(); : sidecar_buf->assign_copy(serialized_buf, serialized_len); > Not this change but this can in theory be converted to sidecar using Slice Done http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/service/control-service.cc File be/src/service/control-service.cc: http://gerrit.cloudera.org:8080/#/c/14777/3/be/src/service/control-service.cc@120 PS3, Line 120: static Status GetSidecar(int sidecar_idx, RpcContext* rpc_context, T* thrift_obj) { > static Done -- To view, visit http://gerrit.cloudera.org:8080/14777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a4dd302fd5602ec2775492a041ddd51e7d7a6c6 Gerrit-Change-Number: 14777 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 03 Dec 2019 18:58:50 +0000 Gerrit-HasComments: Yes
