Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/7/tests/webserver/test_web_pages.py@743 PS7, Line 743: self.assert_impalad_log_contains > I think I need to reset the log directory location here. assert_log_contain This is all a little brittle cause when you run a test cluster with start-impala-cluster.py for development, it puts the logs in /cluster, but when it's run as part of a full test run, it puts the logs in /ee_tests. It's more important for this to pass as part of the full test rul, so assert_log_contains() is doing the right thing by default. It's just annoying for local development. If you start your test cluster with the below command it should be equivalent to the jenkins run... start-impala-cluster.py" --log_dir="${IMPALA_EE_TEST_LOGS_DIR}" -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 7 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2019 19:34:26 +0000 Gerrit-HasComments: Yes
