Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14782 )
Change subject: IMPALA-9182: Print the socket address of the client closing a session or cancelling a query from the WebUI ...................................................................... Patch Set 8: (1 comment) Sorry for the slow response here, I lost track of this in the shuffle. Still concerned about the potential flakiness of the test, but I checked it out and played around so I could suggest a better solution. http://gerrit.cloudera.org:8080/#/c/14782/8/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14782/8/tests/webserver/test_web_pages.py@744 PS8, Line 744: self.assert_impalad_log_contains("INFO", "Cancelled from Impala\'s debug web " This is still flaky for me. It fails immediately when I loop it because it expects exactly one message. There's also an issue with the log buffering (since it buffers for 5 secs by default). We could add sleeps, but that's really undesirable in tests for the most part (unless it's strictly necessary). I prototyped a better version of assert_impalad_log_contains that retries automatically here: https://github.com/timarmstrong/impala/tree/log_asserts . I think that would probably be a better solution. -- To view, visit http://gerrit.cloudera.org:8080/14782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf74ad06ce1c40fab4ce37de6b7ca78e3e520b43 Gerrit-Change-Number: 14782 Gerrit-PatchSet: 8 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 17:41:25 +0000 Gerrit-HasComments: Yes
