Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14665 )
Change subject: IMPALA-9131: Use single quotes around FORMAT clause in CAST ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14665/3/be/src/runtime/datetime-iso-sql-format-parser.cc File be/src/runtime/datetime-iso-sql-format-parser.cc: http://gerrit.cloudera.org:8080/#/c/14665/3/be/src/runtime/datetime-iso-sql-format-parser.cc@219 PS3, Line 219: || strncmp(*format, "\\\\\\'", 4) == 0) > If I left this here then \\\' in the input would have meant double escaped Makes sense, thanks! -- To view, visit http://gerrit.cloudera.org:8080/14665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3310abfa6f3ccbbe4c437846c6dd05791153e6f7 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Anonymous Coward (536) Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Comment-Date: Thu, 28 Nov 2019 17:35:35 +0000 Gerrit-HasComments: Yes
