Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14665 )
Change subject: IMPALA-9131: Use single quotes around FORMAT clause in CAST ...................................................................... Patch Set 4: Actually, that issue with the backslashes followed by a single quote is introduced with this change so should be taken care here. After some investigation what I see is that backslashes are treated differently when given in format or input. - In the format when the user provides \\' it will be parsed as two backslashes and a single quote. - On the contrary when the user gives the same in the input then the two double quotes would be treated as a single one followed by a single quote. The IsSeparator() implementation is changed to accept a double quote followed by a single quote as a single quote, hence the sample output you gave passes. I'm thinking of having two separate implementation of IsSeparator(0 one for the format and one for the input to tackle this difference. -- To view, visit http://gerrit.cloudera.org:8080/14665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3310abfa6f3ccbbe4c437846c6dd05791153e6f7 Gerrit-Change-Number: 14665 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (536) Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Nov 2019 08:11:24 +0000 Gerrit-HasComments: No
