Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14820 )
Change subject: IMPALA-9211: Fix adding new table to stale db due to concurrent reset ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1737 PS1, Line 1737: return db.getTable(tblName); > Isn't this a lightweight op? https://github.com/apache/impala/blob/b421741d Hmm, I looked at the LocalDb implementation by mistake which does load the table if needed: https://github.com/apache/impala/blob/b421741d7f17868958c50b4b19f22d255071472a/fe/src/main/java/org/apache/impala/catalog/local/LocalDb.java#L118 What made me assume that it is loaded is the comment for the function, which says "loading the metadata if needed.", but it seems that actually neither the db or the table is loaded. Can you fix the comment? It also makes sense to me to rename this function to "addIncompleteTable" -- To view, visit http://gerrit.cloudera.org:8080/14820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83d2e5f00eabe61a42c948ec1685ce29cdea1592 Gerrit-Change-Number: 14820 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Dec 2019 17:28:07 +0000 Gerrit-HasComments: Yes
