Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14820 )

Change subject: IMPALA-9211: Fix adding new table to stale db due to concurrent 
reset
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1: Code-Review+1
>
> (1 comment)

http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/14820/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1737
PS1, Line 1737:       return db.getTable(tblName);
> Hmm, I looked at the LocalDb implementation by mistake which does load the
Ah yes, the comment is out-of-date. Removed it and renamed this function.

BTW, LocalDb is only used in Coordinator in Local-Catalog mode (catalog-v2). 
For catalogd, all the catalog objects are still using the legacy implementation.



--
To view, visit http://gerrit.cloudera.org:8080/14820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83d2e5f00eabe61a42c948ec1685ce29cdea1592
Gerrit-Change-Number: 14820
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Wed, 04 Dec 2019 00:26:05 +0000
Gerrit-HasComments: Yes

Reply via email to