Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14810 )
Change subject: IMPALA-9202: Fix flakiness in test_executor_groups ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Only a few nits, feel free to ignore them http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@117 PS1, Line 117: """Assert with a timeout of 60 sec that the expected_str exists in the nit: maybe mention that the 1 is the interval? http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@120 PS1, Line 120: query_handle)) nit: maybe indent in a more pythonic way (start under the 6) It might also look a bit cleaner to define a small helper instead of using a lambda -- To view, visit http://gerrit.cloudera.org:8080/14810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e Gerrit-Change-Number: 14810 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 00:22:50 +0000 Gerrit-HasComments: Yes
