Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/14810 )
Change subject: IMPALA-9202: Fix flakiness in test_executor_groups ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@117 PS1, Line 117: """Assert with a timeout of 60 sec and a polling interval of 1 sec that the > nit: maybe mention that the 1 is the interval? Done http://gerrit.cloudera.org:8080/#/c/14810/1/tests/custom_cluster/test_executor_groups.py@120 PS1, Line 120: 60, 1, lambda: expected_str in self.client.get_runtime_profile(query_handle)) > nit: maybe indent in a more pythonic way (start under the 6) fixed the formatting. I tried following how assert_eventually was being used elsewhere in the code, that is, passing a lambda to it. I dont have a preference either way so will keep this unchanged for now. -- To view, visit http://gerrit.cloudera.org:8080/14810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47070045250a12d86c99f9a30a956a268be5fa7e Gerrit-Change-Number: 14810 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 19:02:59 +0000 Gerrit-HasComments: Yes
