Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/14705/1/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@155 PS1, Line 155: date > Yes, we expect Date type columns to be a part of primary key. New test will Do you plan to add that new test in this patchset or in a separate one? -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 19:41:18 +0000 Gerrit-HasComments: Yes
