Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14705 )
Change subject: Added support of Kudu DATE type to Impala ...................................................................... Patch Set 3: One thing I think is missing here - adding support for DATE to our min-max runtime filters. I think its fine to leave that for a followup patch, though please file a JIRA for it, but you'll probably also need to make sure in this patch that we aren't trying to create DATE min-max filters, which would probably result in a crash. If you're not sure how to write a query that will generate a min-max filter in order to test this, feel free to reach out to me. See the DECIMAL patch for how they temporarily avoided generated DECIMAL min-max filters: https://gerrit.cloudera.org/#/c/9368/10/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java -- To view, visit http://gerrit.cloudera.org:8080/14705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91656749a58ac769b54c2a63bdd4f85c89520b32 Gerrit-Change-Number: 14705 Gerrit-PatchSet: 3 Gerrit-Owner: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Mon, 16 Dec 2019 19:53:10 +0000 Gerrit-HasComments: No
