Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14813 )
Change subject: IMPALA-9162: Do not apply new inferred predicate to outer joins ...................................................................... Patch Set 1: (4 comments) Thank Aman for digging into this! This patch makes sense to me. While trying to understand why we infer such a predicate, I found a bug in constructing the valueTransferGraph. I left a comment in the JIRA to explain it. (Sorry that JIRA comment is more formattable than Gerrit so I leave it there) Could you also fix it so we won't have chance to infer wrong predicates? http://gerrit.cloudera.org:8080/#/c/14813/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/14813/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@29 PS1, Line 29: import java.util.ListIterator; nit: keep the import list sorted http://gerrit.cloudera.org:8080/#/c/14813/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1266 PS1, Line 1266: * : * @param viewRef : * @param preds nit: don't need these http://gerrit.cloudera.org:8080/#/c/14813/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1273 PS1, Line 1273: nit: double whitespaces http://gerrit.cloudera.org:8080/#/c/14813/1/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test File testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test: http://gerrit.cloudera.org:8080/#/c/14813/1/testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test@2228 PS1, Line 2228: nit: use whitespaces instead of tabs -- To view, visit http://gerrit.cloudera.org:8080/14813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9521bd768c4b333069c34d5c1e11b10ea535827 Gerrit-Change-Number: 14813 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 07:10:04 +0000 Gerrit-HasComments: Yes
