Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14813 )

Change subject: IMPALA-9162: Do not apply inferred predicate to outer joins
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java
File fe/src/main/java/org/apache/impala/analysis/Analyzer.java:

http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2238
PS2, Line 2238:           LOG.trace("Considering value transfer between " + 
slotRefs.first.getSlotId().toString() +
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2244
PS2, Line 2244:           g.addEdge(slotRefs.first.getSlotId().asInt(), 
slotRefs.second.getSlotId().asInt());
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2246
PS2, Line 2246:             LOG.trace("value transfer: from " + 
slotRefs.first.getSlotId().toString() + " to " +
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2253
PS2, Line 2253:           g.addEdge(slotRefs.second.getSlotId().asInt(), 
slotRefs.first.getSlotId().asInt());
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/14813/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2255
PS2, Line 2255:             LOG.trace("value transfer: from " + 
slotRefs.second.getSlotId().toString() + " to " +
line too long (97 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14813
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9521bd768c4b333069c34d5c1e11b10ea535827
Gerrit-Change-Number: 14813
Gerrit-PatchSet: 2
Gerrit-Owner: Aman Sinha <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Fri, 06 Dec 2019 02:27:08 +0000
Gerrit-HasComments: Yes

Reply via email to