Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3 ...................................................................... Patch Set 1: (14 comments) Thanks for taking care of this! http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@9 PS1, Line 9: and nit: are? http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12 PS1, Line 12: TZM TZH http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12 PS1, Line 12: IMPALKA nit: IMPALA http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@407 PS1, Line 407: MONTH Can you also mention that the case is also important when this token is given in the format? e.g. MONTH, Month, month would require different casing of the input in a string to datetime conversion and would produce differently cased outputs in a datetime to string conversion? e.g. respectively "JULY", "July", "july" http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@410 PS1, Line 410: Month name "Full month name" would be more self-explanatory http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413 PS1, Line 413: string to date/time conversions For string to datetime conversions could you please add that the expected inputs are in the form of the textual month name without trailing spaces ("June", "August" etc.) but if an FX modifier is active for the token then trailing spaces are also expected ("June ", "August ")? http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413 PS1, Line 413: returns nit: converts to http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@415 PS1, Line 415: <p> : In date/time to string conversions, returns a 9-character-long full : month name with trailing spaces. : </p> I'd also mention that providing FM modifier for this token would result in omitting the trailing spaces. http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@423 PS1, Line 423: <codeph>MON</codeph> Similarly to the month token can you mention the differences between MON, Mon, mon? http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@432 PS1, Line 432: <codeph>WW</codeph> Coudl you mention that 1st week begins on January 1st and ends on the 7th, and so on? This is relevant as milestone 4 will have a new week numbering token besides this where the 1st week starts from the first Monday of the year. http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@445 PS1, Line 445: <codeph>W</codeph> Again, please add: 1st week starts on the 1st of the month and ends on the 7th, and so on. http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@458 PS1, Line 458: <codeph>D</codeph> Please add: 1 means Sunday, 2 means Monday, and so on. http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@500 PS1, Line 500: <codeph>DAY</codeph> Please mention the following things similarly to the full month name token: - Differences between DAY, Day and day - In datetime to string conversion an FM modifier can be used to omit trailing spaces. http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@520 PS1, Line 520: <codeph>DY</codeph> Please mention DY, Dy, and dy for different cases. -- To view, visit http://gerrit.cloudera.org:8080/14861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b Gerrit-Change-Number: 14861 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 12:34:11 +0000 Gerrit-HasComments: Yes
