Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 )
Change subject: IMPALA-9092: Add support for creating external Kudu table ...................................................................... Patch Set 7: (12 comments) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@455 PS7, Line 455: "compatible with partitioning column 'ts' (type: TIMESTAMP).", isExternalPurgeTbl); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@267 PS7, Line 267: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@268 PS7, Line 268: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@269 PS7, Line 269: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@271 PS7, Line 271: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@272 PS7, Line 272: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@273 PS7, Line 273: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@274 PS7, Line 274: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@275 PS7, Line 275: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@276 PS7, Line 276: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/14750/7/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/14750/7/tests/query_test/test_kudu.py@1053 PS7, Line 1053: ' flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/7/tests/query_test/test_kudu.py@1072 PS7, Line 1072: ' flake8: E501 line too long (95 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/14750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76f81d41db0cf2269ee1b365857164a43677e14d Gerrit-Change-Number: 14750 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 22:40:35 +0000 Gerrit-HasComments: Yes
