Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 )
Change subject: IMPALA-9092: Add support for creating external Kudu table ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Thanks for putting this together. This looks good to me. http://gerrit.cloudera.org:8080/#/c/14750/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/14750/6/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@263 PS6, Line 263: String output = ToSqlUtils.getCreateTableSql(t); > I updated the file based on Joe's suggestion. Can you please take a relook? I believe the suggestion was something like: (Before the if, so it has the same indent as before) String expectedSynchronizedPrefix = "CREATE ..." + " ..." + String expectedUnsynchronizedPrefix = ... // etc etc String output = ToSqlUtils.getCreateTable(t); if (areDefaultSynchronizedTablesExternal) { Assert.assertThat(output, CoreMatchers.startsWith(expectedSynchronizedPrefix)); } else { Assert.assertThat(output, CoreMatchers.startsWith(expectedUnsynchronizedPrefix)); } (There are probably better variable names) I'm ok with the new one, but I would also like Quanlong's suggestion. His preference takes priority over mine. -- To view, visit http://gerrit.cloudera.org:8080/14750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76f81d41db0cf2269ee1b365857164a43677e14d Gerrit-Change-Number: 14750 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 22:36:32 +0000 Gerrit-HasComments: Yes
